-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create a secured cluster with ACL for validation #57
Conversation
Signed-off-by: Jorge Aguilera <jorge@edn.es>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge ✅
Though I do suggest that we hold off a it before merging the PR/ or making a new release till we have had a sync regarding the next steps - what do you think? @jhaezebr @jagedn
Ideally we can also cover the HTTPS setup in this iteration together, since a prod cluster would actually make use of SSL certs.
yes, good idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Later we can add some more specific policies to test with minimal permissions
Good then @jhaezebr , could you please setup HTTPS in the Also, quick reminder if you're going to change the terraform template, could you please make the |
This would mean that the nomad cluster UI is open to the internet. Is that safe enough? |
Security wise I would not advise opening up the nomad server api ports. The added step to start an ssh tunnel isn't too much overhead during development. If the use case is automatic testing that can be managed by running a self-hosted runner since those only do outgoing long-poll requests over https and no incoming ports need to be opened. |
Ah good point - then perhaps we can just
In case that's not secure or useful then please feel free to disagree and suggest what you feel is the best option, happy to go along with that 👍 The baseline idea is to have as less of a friction in dev-time iterations as possible :) |
If you provide the
--secure
argument when creating the local cluster the script will initialize it using ACLThe management token will be showed by console. You need to provide this token (i.e. NOMAD_TOKEN env) to run the pipeline