-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to nf-schema 2: samplesheetToList
not found in plugin/nf-schema
#28
Comments
Have you tried deleting the cache?
|
Confirming I can recreate this error with a brand new install of Not clear exactly what the issue is, given I guess it may relate to the fact the method is defined with overloading (none of the other methods imported successfully are) |
Removing cache did not fix this for me.
Odd, |
What version of Nextflow are you using? At first I would think this is some nextflow bug, but I'm not sure yet. I'll give it a try later |
NVM, my last post 😁 all the answers are in your first message |
I just tried the steps you laid out with a fresh install of nf-schema. I didn't get any issues with it :/. Can you point me to a repository where you have this issue? |
When you say a fresh install do you mean a manual install from source? Or letting NF pull it? FWIW my setup used Nextflow 23.10.1 |
I deleted the cache and let Nextflow redownload it. |
After some additional testing I also managed to get it to work by converting all include statements to use |
Ok I have a theory and a bit of testing has me believing I am correct but paging @bentsherman as a groovy/nextflow expert who can hopefully confirm. All the following can be recreated with
So here goes...
Ouput:
Output:
Output:
Output:
So the issue... 🥁 Both I am guessing that what happens is that both plugins are "loaded" but the compiled code of the first one loaded is what is actually available under both plugins. This leads to this seemingly impossible successful
Output:
|
Thank you for investigating! Does this issue still occur with the edge versions of Nextflow? (just curious 😁) |
Seems like the issue is not present in I am only able to do this surface level testing though so I am not clear what happens for methods that exist in both extensions e.g. Will need someone more keyed in with |
Nextflow was upgraded from Groovy 3 to 4 in 24.01.0-edge, which might have something to do with it. But the basic issue seems to be that both plugins are using the same namespace and have some conflicting extensions? I see they both have a |
Technically the issue isn't the conflicting extensions really (eg If nothing in the plugin arch has changed that would support this but the groovy 3->4 change is the cause of the conflict not occurring in |
Using the same namespace by itself isn't necessarily a problem, only if you have two classes with the same fully qualified name e.g. At the same time, a major version bump like Groovy 3 -> 4 can bring many mysterious changes. If the issue went away in Groovy 4, maybe they improved something in the class loader which can handle the duplicate class names correctly. |
Some additional checks have been implemented in |
Problem occured during migration from
nf-vallidation
tonf-schema
. Aim is to migrate to newere sample sheet reader function.Reproducible steps
nextflow.config
subworkflows/local/utils_nfcore_training_pipeline/main.nf
Error stack
The text was updated successfully, but these errors were encountered: