-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nf-core v2.14 update #99
Conversation
Still need to fix linting issues, not ready for review |
ready for review |
I'm not sure if this is intended or not but when you run the pipeline using the test profile it now asks for an --outdir param because the default value in modules.config has changed from "./results" to null. This makes sense as the docs say this is a required parameter but do we want to maybe set a default value for --outdir in the test and test_full profiles? |
Solves #70
(1) nf-core v2.13 migration:
lib/
directory in favour of new boilerplate sub workflowsnf_validation
for sample sheet checking + removal of local module for sample sheet checking -> validated sample sheet is now passed directly toinput_check.nf
sub workflow, which just runsSAMTOOLS_FLAGSTAT
and formats channels for alignment sub workflows.PIPELINE_INITIALISATION
andPIPELINE_COMPLETION
defined insubworkflows/local/utils_nfcore_readmapping_pipeline
(2) nf-core v2.14 migration
.github/workflows
were rejected, with exception of: (a) added newdownload_pipelines.yml
; (b) update nf-core setup version inci.yml
TEMPLATE
branch Template update for nf-core/tools version 2.14.1 #98)(3) Other
NOTES:
INPUT_CHECK
sub workflow now only has a single module step, so could probably be removed and just call the module directly inreadmapping.nf
nextflow.config
... This is needed bynf-validation
. This is fixed innf-schema
, howevernf-schema
can't be used alongsidenf-validation
, which is still required bysubworkflows/nf-core/utils_nfvalidation_plugin
so for now I stick tonf-validation:1.13
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).