Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support $defs #40

Merged
merged 2 commits into from
Aug 5, 2024
Merged

support $defs #40

merged 2 commits into from
Aug 5, 2024

Conversation

nvnieuwk
Copy link
Collaborator

@nvnieuwk nvnieuwk commented Aug 2, 2024

Definitions in JSON schema draft 2020-12 should be $defs instead of defs (if we want to follow the guidelines set up by JSON schema). This PR fixes that while keeping backwards compatibility for defs

https://json-schema.org/understanding-json-schema/structuring#defs

@nvnieuwk nvnieuwk requested a review from mirpedrol August 2, 2024 15:12
Copy link
Collaborator

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nvnieuwk nvnieuwk merged commit 5a24da2 into master Aug 5, 2024
4 checks passed
@nvnieuwk nvnieuwk deleted the fix/support-$defs branch August 5, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants