Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4 maven/tycho 1.0.0 pomless build #5

Merged
merged 1 commit into from
Nov 9, 2017

Conversation

paulvi
Copy link
Collaborator

@paulvi paulvi commented Nov 9, 2017

2nd build with maven/tycho 1.0.0 pomless build.

Note that feature id was the same as plugin id, so it was changed.

This is not clean PR, because of whitespaces changes.
See https://github.com/nextinterfaces/http4e/compare/master...Nodeclipse:master?w=1 without
whitespaces

I still cannot figure out why EGit does so.

@nextinterfaces
Copy link
Owner

Thanks @paulvi

@nextinterfaces nextinterfaces merged commit eaead61 into nextinterfaces:master Nov 9, 2017
@paulvi
Copy link
Collaborator Author

paulvi commented Nov 9, 2017

You need to check that ant build works, as I have to done so after changing feature id

For example https://github.com/nextinterfaces/http4e/blob/master/site.xml still references old feature id

Also changing feature id, will make trouble when users update, as they will have 2 plugins (I guess so)

@nextinterfaces
Copy link
Owner

Ant works. feature id is a manual version bump process, I can do it, just wondering why do we need to change it? And if so to what version? Thanks

paulvi pushed a commit to paulvi/http4e that referenced this pull request Nov 10, 2017
@paulvi
Copy link
Collaborator Author

paulvi commented Nov 10, 2017

Tycho build is more strict, so it did not allow feature and plugin to have the same id org.roussev.http4e.ui
More logical was to change feature, not plugin id. So now it is org.roussev.http4e.feature.

Version is separate issue. There is maven one-liner command in README to bump version to new in all places (all plugins, feature, pom's), except site.

nextinterfaces added a commit that referenced this pull request Nov 10, 2017
ref #4 change feature id as .feature similar to #5
@nextinterfaces
Copy link
Owner

nextinterfaces commented Nov 10, 2017

Probably we should drop ant build altogether and rely purely on maven?

Also org.roussev is a dated name space, feel free if you have time, to rename org.roussev.http4e to --> com.nextinterfaces.http4e.

@paulvi
Copy link
Collaborator Author

paulvi commented Nov 10, 2017

Probably we should drop ant build altogether and rely purely on maven?

in long run definitely yes, now it is a perl to see Ant build still working.

Also org.roussev is a dated name space

usually base package name should be the same as id base.
So that would be huge refactoring to change all to something new.

@paulvi paulvi mentioned this pull request Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants