New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include file in repo that contains CAS-hash to JS asset #102

Closed

2 tasks

borkdude opened this issue Mar 1, 2022 · 0 comments · Fixed by #107

Closed

2 tasks

Include file in repo that contains CAS-hash to JS asset #102

borkdude opened this issue Mar 1, 2022 · 0 comments · Fixed by #107

Assignees

Collaborator

borkdude commented Mar 1, 2022 •

edited

Loading

This solves the problem of not having to change the source in CI when building the JS.

This hash can be calculated fast using dejavu + bb and will be populated on every commit using a git pre-commit hook
The JS asset itself will be built on CI and uploaded using this hash
For local development, the hash will be ignored and the locally built JS will be used.

This change is necessary to reliably test changes in the UI, see #97

/cc @mk

TODO:

upload static asset via dejavu using 512 hash
update lookup link to point to 512 hash

borkdude self-assigned this

borkdude mentioned this issue

Write hash in pre-commit hook for predicable viewer.js location, build JS in CI #107

Merged

borkdude closed this as completed in #107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment