Remove column truncation #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Column names were hidden when there were many columns
|
Interestingly, once the column names do not collapse it looks like the number of columns displayed is limited, but not the column names. As seen here:
But this also seems a bit out of scope for this PR perhaps... The issue seems to be that the value that value that |
ezmiller
commented
Apr 2, 2022
| @@ -481,9 +481,8 @@ | |||
| :title (if (or (string? k) (keyword? k)) (name k) (str k))} | |||
| [:div.inline-flex | |||
| ;; Truncate to available col width without growing the table | |||
| [:div.table.table-fixed.w-full.flex-auto | |||
| {:style {:margin-left -12}} | |||
There was a problem hiding this comment.
Hmmm, looking at examples in notebooks/viewers/table.clj this seems to align certain columns correctly. Most of the tables look weird without this. Eg.:
But then my test looks strange with it:
Seems like the check for `sort-key` should have been around the clause rendering a up or down arrow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When there are a lot of columns in a table rendered using the
nextjournal.clerk.sci-viewer/table-viewer, the column names are truncated:This makes the exploration of datasets with many columns very difficult.
(One) Solution
One fix seems to be to remove the tailwind
truncateclass that is being used on the markup for the table, and to modify the CSS slightly to layout the value so it is lined up against the edge of the column name:This way of handling things mimics how, for example, Pandas dataframes are rendered in a python notebook: