-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java Path value causes non-termination error in clerk/show! #199
Comments
@jackrusher also asked if I observe any browser console errors when this happens. I haven't seen any alongside this issue, in part because it doesn't seem to me like values are even getting across the JVM <> browser boundary. |
@respatialized thanks for the report, I can reproduce it on my end. |
The problem is clerk/src/nextjournal/clerk/analyzer.clj Lines 368 to 378 in 80c646d
See (seq (.toPath (clojure.java.io/file "something")));;=> (#object[sun.nio.fs.UnixPath 0x5aa4c178 "something"])
(take 10 (tree-seq seqable? seq (.toPath (clojure.java.io/file "something"))))
;;=> (#object[sun.nio.fs.UnixPath 0x7307e110 "something"] #object[sun.nio.fs.UnixPath 0x35cacee7 "something"] #object[sun.nio.fs.UnixPath 0x3de508 "something"] #object[sun.nio.fs.UnixPath 0x4c185902 "something"] #object[sun.nio.fs.UnixPath 0xdb3ef0 "something"] #object[sun.nio.fs.UnixPath 0x630565fa "something"] #object[sun.nio.fs.UnixPath 0xc7fc937 "something"] #object[sun.nio.fs.UnixPath 0x22141f3 "something"] #object[sun.nio.fs.UnixPath 0x5b54d3f9 "something"] #object[sun.nio.fs.UnixPath 0x13b647dc "something"]) |
@respatialized the issue should be fixed with the commit above which just landed in |
Previously reported on Clojurians; recording here for posterity as requested by @mk.
Description
Using
java.nio.Path
objects as values in a notebook causes a notebook to never successfully evaluate. It never reaches theClerk evaluated 'src/clerk_errors.clj' in ... ms
step.Expected behavior
The notebook renders correctly using the string representation of a
Path
. Failing that, an error message is at least thrown somewhere so I don't have to manually interrupt notebook evaluation.Reproducing the issue
If the above
fs/path
call is uncommented and evaluated withclerk/show!
, the notebook hangs, never evaluating. Regular evaluation works fine.The text was updated successfully, but these errors were encountered: