Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example macro #407

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Fix example macro #407

merged 1 commit into from
Feb 6, 2023

Conversation

pfeodrippe
Copy link
Contributor

@pfeodrippe pfeodrippe commented Feb 6, 2023

Before, the user had to have nextjournal.clerk aliased to clerk in their namespace or they would have an exception.

Before, the user had to have `nextjournal.clerk` aliased to `clerk` in
their namespace or you would have an exception.
Copy link
Member

@mk mk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks @pfeodrippe!

@@ -346,7 +346,7 @@
Does nothing outside of Clerk, like `clojure.core/comment`."
[& body]
(when nextjournal.clerk.config/*in-clerk*
`(clerk/with-viewer v/examples-viewer
`(nextjournal.clerk/with-viewer v/examples-viewer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`(with-viewer ,,,

Would also work, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep :D thanks

@mk mk merged commit 45d2fe1 into nextjournal:main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants