Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[Basic theme] Icons and svg variations generator #9

Closed
wants to merge 15 commits into from

Conversation

TSI-nareshrai
Copy link
Contributor

We have replaced nextcloud icons with magenta icons using sass variables only

@TSI-nareshrai TSI-nareshrai added the build-ready Mark MagentaCLOUD Cutomisation for inclusion in build label May 19, 2023
@tsdicloud
Copy link
Member

Please use standard Nextcloud generative approach and CSS recommendation:
https://docs.nextcloud.com/server/latest/developer_manual/html_css_design/css.html#css-variables
https://help.nextcloud.com/t/scss-support-dropped-with-nextcloud-25/141471

This need to reuse Nextcloud icon generator for SASS and the support of the upstream commands:

 "sass": "sass --style compressed --load-path core/css core/css/ apps/*/css",
  "sass:icons": "babel-node core/src/icons.js"
 ``

@tsdicloud tsdicloud changed the title Updated magenta icons using sass variables [Basic theme] Icons and sig variations generator Jun 14, 2023
@tsdicloud tsdicloud changed the title [Basic theme] Icons and sig variations generator [Basic theme] Icons and svg variations generator Jun 14, 2023
@tsdicloud
Copy link
Member

tsdicloud commented Jun 14, 2023

Please don't separate this PR from #17, pictures and icon generation should be kept together.

@tsdicloud
Copy link
Member

tsdicloud commented Jun 14, 2023

Please plan also a separate server PR/branch so that we can upstream our recommended changes on the icon generator.
(summary: differentiate between a replaced custom icon and an newly introduced one which also needs aliases etc.)

@tsdicloud
Copy link
Member

Please make sure that the following best practices of Nextcloud are followed:
nextcloud/server#32060

@tsdicloud tsdicloud removed the build-ready Mark MagentaCLOUD Cutomisation for inclusion in build label Jun 26, 2023
@tsdicloud tsdicloud added the invalid This doesn't seem right label Jun 28, 2023
Guest view page icons are added
@tsdicloud tsdicloud closed this Jul 14, 2023
@tsdicloud tsdicloud deleted the nmc/2007-basic-theme-icons branch July 14, 2023 13:59
@tsdicloud tsdicloud removed invalid This doesn't seem right custom labels Jul 19, 2023
@tsdicloud tsdicloud added the iteration25 Experimental release 25 (review material only) label Jul 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iteration25 Experimental release 25 (review material only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants