Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

731-Settings-Replace username with email address #206

Closed

Conversation

TSI-kavitasonawane
Copy link

This PR contains the following changes:

Devices & Sessions page(Settings): Replace username with email address

@TSI-kavitasonawane TSI-kavitasonawane added the custom MagentaCLOUD customisation label Apr 21, 2023
@tsdicloud
Copy link
Member

Please explain in PR why this customisation is still needed or find a way to
upstream it as an option to Nextcloud server

@TSI-kavitasonawane
Copy link
Author

Please explain in PR why this customisation is still needed or find a way to upstream it as an option to Nextcloud server

Jens already confirmed with nextcloud and they rejected to upstream it.
so we need to keep this in customisation.

@tsdicloud
Copy link
Member

Can't we fix this in User interface as we have to add reading the user anyway to the core and user is maybe already available in UI?

@tsdicloud
Copy link
Member

Check whether the requirement is still correct as we now generally use display name, not email
as displayed user login.

Find all places in UI where this change gets relevant. If, after identification, we
need to keep the change, write safeguarding unittests for all occurrences.

@TSI-kavitasonawane
Copy link
Author

I have renamed this branch with same changes to follow the new branch naming-conventions for new delivery model.
so hence raising new PR by closing this one.

New PR link - #219

@tsdicloud tsdicloud deleted the nmcfeat/731-settings-mail-address-username branch July 14, 2023 12:37
@tsdicloud tsdicloud added iteration25 Experimental release 25 (review material only) and removed custom MagentaCLOUD customisation labels Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iteration25 Experimental release 25 (review material only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants