update prebid-serer bidder params for impressions (prebid#11982)

nextmillenniummedia · Jul 17, 2024 · cdd3b5a · cdd3b5a
1 parent 730d679
commit cdd3b5a
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 32 deletions.
diff --git a/modules/insticatorBidAdapter.js b/modules/insticatorBidAdapter.js
@@ -107,19 +107,8 @@ function buildVideo(bidRequest) {
  const playerSize = deepAccess(bidRequest, 'mediaTypes.video.playerSize');
  const context = deepAccess(bidRequest, 'mediaTypes.video.context');
 
- if (!w && playerSize) {
- if (Array.isArray(playerSize[0])) {
- w = parseInt(playerSize[0][0], 10);
- } else if (typeof playerSize[0] === 'number' && !isNaN(playerSize[0])) {
- w = parseInt(playerSize[0], 10);
- }
- }
- if (!h && playerSize) {
- if (Array.isArray(playerSize[0])) {
- h = parseInt(playerSize[0][1], 10);
- } else if (typeof playerSize[1] === 'number' && !isNaN(playerSize[1])) {
- h = parseInt(playerSize[1], 10);
- }
+ if (!h && !w && playerSize) {
+ ({w, h} = parsePlayerSizeToWidthHeight(playerSize, w, h));
  }
 
  const bidRequestVideo = deepAccess(bidRequest, 'mediaTypes.video');
@@ -173,6 +162,14 @@ function buildImpression(bidRequest) {
  },
  }
 
+ if (bidRequest?.params?.adUnitId) {
+ deepSetValue(imp, 'ext.prebid.bidder.insticator.adUnitId', bidRequest.params.adUnitId);
+ }
+
+ if (bidRequest?.params?.publisherId) {
+ deepSetValue(imp, 'ext.prebid.bidder.insticator.publisherId', bidRequest.params.publisherId);
+ }
+
  let bidFloor = parseFloat(deepAccess(bidRequest, 'params.floor'));
 
  if (!isNaN(bidFloor)) {
@@ -247,7 +244,7 @@ function buildDevice(bidRequest) {
  const device = {
  w: window.innerWidth,
  h: window.innerHeight,
- js: true,
+ js: 1,
  ext: {
  localStorage: storage.localStorageIsEnabled(),
  cookies: storage.cookiesAreEnabled(),
@@ -569,24 +566,12 @@ function validateVideo(bid) {
  let w = deepAccess(bid, 'mediaTypes.video.w');
  let h = deepAccess(bid, 'mediaTypes.video.h');
  const playerSize = deepAccess(bid, 'mediaTypes.video.playerSize');
- if (!w && playerSize) {
- if (Array.isArray(playerSize[0])) {
- w = parseInt(playerSize[0][0], 10);
- } else if (typeof playerSize[0] === 'number' && !isNaN(playerSize[0])) {
- w = parseInt(playerSize[0], 10);
- }
- }
- if (!h && playerSize) {
- if (Array.isArray(playerSize[0])) {
- h = parseInt(playerSize[0][1], 10);
- } else if (typeof playerSize[1] === 'number' && !isNaN(playerSize[1])) {
- h = parseInt(playerSize[1], 10);
- }
+
+ if (!h && !w && playerSize) {
+ ({w, h} = parsePlayerSizeToWidthHeight(playerSize, w, h));
  }
- const videoSize = [
- w,
- h,
- ];
+
+ const videoSize = [w, h];
 
  if (
  !validateSize(videoSize)
@@ -625,6 +610,25 @@ function validateVideo(bid) {
  return true;
 }
 
+function parsePlayerSizeToWidthHeight(playerSize, w, h) {
+ if (!w && playerSize) {
+ if (Array.isArray(playerSize[0])) {
+ w = parseInt(playerSize[0][0], 10);
+ } else if (typeof playerSize[0] === 'number' && !isNaN(playerSize[0])) {
+ w = parseInt(playerSize[0], 10);
+ }
+ }
+ if (!h && playerSize) {
+ if (Array.isArray(playerSize[0])) {
+ h = parseInt(playerSize[0][1], 10);
+ } else if (typeof playerSize[1] === 'number' && !isNaN(playerSize[1])) {
+ h = parseInt(playerSize[1], 10);
+ }
+ }
+
+ return { w, h };
+}
+
 export const spec = {
  code: BIDDER_CODE,
  gvlid: GVLID,

diff --git a/test/spec/modules/insticatorBidAdapter_spec.js b/test/spec/modules/insticatorBidAdapter_spec.js
@@ -389,7 +389,7 @@ describe('InsticatorBidAdapter', function () {
  expect(data.device).to.be.an('object');
  expect(data.device.w).to.equal(window.innerWidth);
  expect(data.device.h).to.equal(window.innerHeight);
- expect(data.device.js).to.equal(true);
+ expect(data.device.js).to.equal(1);
  expect(data.device.ext).to.be.an('object');
  expect(data.device.ext.localStorage).to.equal(true);
  expect(data.device.ext.cookies).to.equal(false);
@@ -439,6 +439,13 @@ describe('InsticatorBidAdapter', function () {
  insticator: {
  adUnitId: bidRequest.params.adUnitId,
  },
+ prebid: {
+ bidder: {
+ insticator: {
+ adUnitId: bidRequest.params.adUnitId,
+ }
+ }
+ }
  }
  }]);
  expect(data.ext).to.be.an('object');