-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge additional data during phylogenetic (instead of ingest) workflow #68
base: main
Are you sure you want to change the base?
Conversation
if uri.startswith('s3://'): | ||
return s3 | ||
elif uri.lower().startswith('http://') or uri.lower().startswith('https://'): | ||
raise InvalidConfigError("Workflow cannot yet handle HTTP[S] inputs") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to add support for HTTP[S] inputs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but there may be better ways of doing it than this. See this reply to the zika PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I'm comfortable continuing to use S3 inputs for WNV for now, as it simplifies documenting the API
Description of proposed changes
This PR refines our approach to merging private data—such as latitude and longitude annotations for samples collected at mosquito traps—into state-level phylogenetic trees (e.g. Washington). Previously, we merged private data during the
ingest
workflow by extending anannotations.tsv
file. This led to a convolutedphylogenetic
config file that varied depending on whether data was sourced from S3 or from theingest/results/*
merged files.In this update, private user data is incorporated directly during the
phylogenetic
workflow. We adopt a variation of theconfig.additional_inputs
method (copied and modified from these lines in avian-flu) and further advocates for a generic pattern for including additional user data as being explored in the pathogen-repo-guide#72.Config changes
Before
After
This updated configuration greatly simplifies our documentation, making it easier for other states to modify the Washington state builds and incorporate their own private data.
Related issue(s)
Checklist