Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Download Auspice JSON" does not work #93

Open
ivan-aksamentov opened this issue Jul 30, 2024 · 1 comment
Open

"Download Auspice JSON" does not work #93

ivan-aksamentov opened this issue Jul 30, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ivan-aksamentov
Copy link
Member

Current Behavior

When loading a nwk file:

((A:0.1,(B:0.2,C:0.3,D:0.4)BCD:0.5)ABCD:0.6,(E:0.7,F:0.8)EF:0.9,(G:1.0,H:1.1,I:1.2,J:1.3)GHIJ:1.4)ABCDEFGHIJ:1.5;

The tree is displayed fine.

But when clicking on "Download Auspice JSON" in the "Download data" dialog, the download does not happen.

A notification toast is displayed with "Preparing Auspice JSON(s) for download: " (without filename)

I also tried with some random Auspice JSON tree I had laying around, and download did not work either.

My goal was to obtain a canonical nwk-to-auspice conversion in order to reproduce and test the same conversion in another project. But I left empty handed :(

I checked on nextstrain.org and for SARS-CoV-2 the JSON download works. It also displays a filename in the toast.

Expected behavior

Download starts when "Download Auspice JSON" is clicked

How to reproduce

Steps to reproduce the current behavior:

  1. Open auspice.us
  2. Drop a nwk file posted above
  3. Click "Download data"
  4. Click "Download Auspice JSON"
  5. Observe that doesnload does not start

Possible solution

(optional)

Your environment: if browsing Nextstrain online

Chromium 126

Your environment: if running Nextstrain locally

N/A

Additional context

N/A

@ivan-aksamentov ivan-aksamentov added the bug Something isn't working label Jul 30, 2024
@joverlee521
Copy link
Contributor

Ah, thanks for flagging this feature doesn't work in auspice.us!

Auspice is not generating the JSON but tries to fetch the original dataset based on the URL. Auspice should do a better job here of notifying that no datasets were available for download. Maybe we should even hide the download option here.

My goal was to obtain a canonical nwk-to-auspice conversion in order to reproduce and test the same conversion in another project.

auspice.us does convert the newick tree to an Auspice JSON so we might be able to surface that just within auspice.us? Not entirely sure what the UI/UX would be like here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants