Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branches change color on hover when coloring by genotype #1903

Closed
corneliusroemer opened this issue Nov 16, 2024 · 2 comments · Fixed by #1907
Closed

Branches change color on hover when coloring by genotype #1903

corneliusroemer opened this issue Nov 16, 2024 · 2 comments · Fixed by #1907
Labels
bug Something isn't working priority: high To be resolved before other issues

Comments

@corneliusroemer
Copy link
Member

corneliusroemer commented Nov 16, 2024

On next.nextstrain.org (v2.61.1) I encountered something super weird: branches would change color when hovering over them when coloring by genotype.

See attached GIF for a demonstration (this was captured on mpox clade I build):
2024-11-16 17 09 29

https://next.nextstrain.org/mpox/clade-I?c=gt-nuc_107670&gmax=108670&gmin=106670&m=div&r=location

It appears that the new color after hovering is correct - so it seems that the bug is that the color didn't update earlier, and also that the tips don't ever change color the way they should.

@corneliusroemer corneliusroemer added the bug Something isn't working label Nov 16, 2024
@jameshadfield jameshadfield added the priority: high To be resolved before other issues label Nov 17, 2024
@jameshadfield
Copy link
Member

We've had a bug similar to this in the past which was triggered by multiple d3 updates issued in quick succession (e.g. change colour and change position); the updates essentially overlap and cause the very strange out-of-sync errors that you see here. When hovering over branches we change the colour to highlight the hovered branch which has the side-effect of setting the correct colour; tips don't have this behaviour which explains what's happening in your screenshare above.

Loading the URL doesn't recreate the bug, which matches my expectation that it's generated by a particular set of actions. If you find a series of steps which reproduces it please share as I'd like to eradicate these kinds of bugs!

@corneliusroemer
Copy link
Member Author

I will let you know if I find a way to reproduce! I need to up my repro skills 🫣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: high To be resolved before other issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants