fix(dropdown): fix dropdown menu unexpected close when closeOnSelect …

…is false (#2290)
nextui-org · Mar 27, 2024 · 8e21dc2 · 8e21dc2
1 parent cf0d4e4
commit 8e21dc2
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/packages/components/menu/src/menu.tsx b/packages/components/menu/src/menu.tsx
@@ -1,5 +1,5 @@
 import {forwardRef} from "@nextui-org/system";
-import {ForwardedRef, ReactElement, Ref} from "react";
+import {ForwardedRef, Key, ReactElement, Ref} from "react";
 
 import {UseMenuProps, useMenu} from "./use-menu";
 import MenuSection from "./menu-section";
@@ -18,7 +18,7 @@ function Menu<T extends object>(props: Props<T>, ref: ForwardedRef<HTMLUListElem
     hideEmptyContent,
     variant,
     onClose,
-    onAction,
+    onAction: onTopAction,
     topContent,
     bottomContent,
     itemClasses,
@@ -27,6 +27,12 @@ function Menu<T extends object>(props: Props<T>, ref: ForwardedRef<HTMLUListElem
     getEmptyContentProps,
   } = useMenu<T>({...props, ref});
 
+  const onAction = (key: Key) => {
+    if (closeOnSelect) {
+      onTopAction?.(key);
+    }
+  };
+
   const content = (
     <Component {...getListProps()}>
       {!state.collection.size && !hideEmptyContent && (