Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): behavior of tooltip trigger with delay #1278

Merged
merged 2 commits into from
Aug 5, 2023

Conversation

tianenpang
Copy link
Member

Closes #1168

📝 Description

The tooltip should not open again after the delay is not reached and the cursor moves out.

⛳️ Current behavior (updates)

Fix the trigger behavior to prevent it from opening again after the delay is not reached and the cursor moves out.

🚀 New behavior

Use triggerProps instead of custom on-pointer events, it already includes the correct pointer behavior.

💣 Is this a breaking change (Yes/No):

No.

📝 Additional Information

Before

before.webm

After

after.webm

@changeset-bot
Copy link

changeset-bot bot commented Aug 5, 2023

🦋 Changeset detected

Latest commit: 9596e14

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@nextui-org/tooltip Patch
@nextui-org/snippet Patch
@nextui-org/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 5, 2023

@tianenpang is attempting to deploy a commit to the NextUI Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@jrgarciadev jrgarciadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Genius! @tianenpang 🎉

@jrgarciadev jrgarciadev merged commit a1a02dc into nextui-org:main Aug 5, 2023
5 checks passed
@github-actions github-actions bot mentioned this pull request Aug 5, 2023
@tianenpang tianenpang deleted the fix/tooltip-with-delay branch August 24, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip delay open after cursor leave
2 participants