Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(navbar): fixed the height of navbar menu #1805

Merged
merged 5 commits into from
Jun 15, 2024
Merged

fix(navbar): fixed the height of navbar menu #1805

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1003820
fix(navbar): fixed the height of navbar menu
nozomemein Oct 25, 2023
e730e8c
fix(navbar): refactored the css of navbar
nozomemein May 25, 2024
6615e77
fix(navbar): fix redundant expression
nozomemein May 25, 2024
a48bd6a
fix(navbar): fixed unnecessary changes
nozomemein May 25, 2024
5202540
fix(navbar): adjust viewport
nozomemein May 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/components/navbar/src/navbar-menu-transitions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import {Variants} from "framer-motion";

export const menuVariants: Variants = {
enter: {
height: "calc(100vh - var(--navbar-height) - 1px)",
height: "calc(100vh - var(--navbar-height))",
transition: {
duration: 0.3,
easings: "easeOut",
Expand Down
1 change: 1 addition & 0 deletions packages/components/navbar/src/navbar-menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ const NavbarMenu = forwardRef<"ul", NavbarMenuProps>((props, ref) => {
style={{
// @ts-expect-error
"--navbar-height": height,
height: "calc(100vh - var(--navbar-height))",
wingkwong marked this conversation as resolved.
Show resolved Hide resolved
}}
{...otherProps}
>
Expand Down