-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(theme): fullWidth in input and select #3768
fix(theme): fullWidth in input and select #3768
Conversation
🦋 Changeset detectedLatest commit: 9fec81d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Someone is attempting to deploy a commit to the NextUI Inc Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe changes in this pull request focus on a patch for the Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
01a34e6
to
b6254a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
.changeset/fast-horses-explode.md (1)
1-5
: LGTM! Consider enhancing the change description.The changeset correctly identifies the package and version bump. The description is concise and informative, aligning well with the PR objectives.
For improved clarity, consider expanding the change description slightly. Here's a suggested revision:
-fix the fullWidth variant in input and select component. (#3745) +fix: Correct fullWidth functionality in Input and Select components (#3745)This revision:
- Uses the conventional commit format.
- Capitalizes component names for consistency with NextUI documentation.
- Clarifies that it's the functionality being fixed, not just the variant.
Closes #3745
📝 Description
⛳️ Current behavior (updates)
Even when the full-width is set to
false
, the component takes the full-width of the parent. This should not be the case.Examples for the bug are:
Screen.Recording.2024-09-16.at.7.20.38.PM.mov
Screen.Recording.2024-09-16.at.7.19.18.PM.mov
🚀 New behavior
The PR fixes the full-width functionality:
Screen.Recording.2024-09-16.at.7.21.23.PM.mov
Screen.Recording.2024-09-16.at.7.22.51.PM.mov
In select the min-w-40 is added so that the select component has atleast width of 10rem.
💣 Is this a breaking change (Yes/No): No
Summary by CodeRabbit
New Features
Bug Fixes
fullWidth
variant in input and select components for improved functionality.Documentation