Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): fullWidth in input and select #3768

Merged

Conversation

macci001
Copy link
Contributor

@macci001 macci001 commented Sep 16, 2024

Closes #3745

📝 Description

Fixes the full width functionality.

⛳️ Current behavior (updates)

Even when the full-width is set to false, the component takes the full-width of the parent. This should not be the case.
Examples for the bug are:

  • Input:
Screen.Recording.2024-09-16.at.7.20.38.PM.mov
  • Select:
Screen.Recording.2024-09-16.at.7.19.18.PM.mov

🚀 New behavior

The PR fixes the full-width functionality:

  • Input
Screen.Recording.2024-09-16.at.7.21.23.PM.mov
  • Select:
Screen.Recording.2024-09-16.at.7.22.51.PM.mov

In select the min-w-40 is added so that the select component has atleast width of 10rem.

💣 Is this a breaking change (Yes/No): No

Summary by CodeRabbit

  • New Features

    • No new features introduced in this update.
  • Bug Fixes

    • Resolved issues with the rendering of the fullWidth variant in input and select components for improved functionality.
  • Documentation

    • Enhanced visual presentation and functionality of dateInput, input, and select components for a better user experience.

Copy link

changeset-bot bot commented Sep 16, 2024

🦋 Changeset detected

Latest commit: 9fec81d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@nextui-org/theme Patch
@nextui-org/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 16, 2024

Someone is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Sep 16, 2024

Walkthrough

The changes in this pull request focus on a patch for the @nextui-org/theme package, specifically addressing the fullWidth variant in the input and select components. The update resolves issues related to the rendering and behavior of the fullWidth property, ensuring correct visual presentation. Modifications include adding empty objects for certain states in the dateInput, input, and select components, as well as styling adjustments to enhance functionality.

Changes

Files Change Summary
packages/core/theme/src/components/date-input.ts Added false: {} in the dateInput configuration object.
packages/core/theme/src/components/input.ts Added false: {} in the isClearable property of the input component.
packages/core/theme/src/components/select.ts Added isFullWidth: false styling option in the select component configuration.

Assessment against linked issues

Objective Addressed Explanation
fullWidth prop of Select component does nothing (#3745)

Possibly related PRs

Suggested reviewers

  • jrgarciadev

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@macci001 macci001 marked this pull request as ready for review September 16, 2024 13:58
@wingkwong wingkwong added this to the v2.5.0 milestone Sep 16, 2024
@wingkwong wingkwong self-assigned this Sep 16, 2024
@wingkwong wingkwong self-requested a review September 16, 2024 14:57
Copy link
Member

@ryo-manba ryo-manba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 3:42pm
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 3:42pm

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
.changeset/fast-horses-explode.md (1)

1-5: LGTM! Consider enhancing the change description.

The changeset correctly identifies the package and version bump. The description is concise and informative, aligning well with the PR objectives.

For improved clarity, consider expanding the change description slightly. Here's a suggested revision:

-fix the fullWidth variant in input and select component. (#3745)
+fix: Correct fullWidth functionality in Input and Select components (#3745)

This revision:

  1. Uses the conventional commit format.
  2. Capitalizes component names for consistency with NextUI documentation.
  3. Clarifies that it's the functionality being fixed, not just the variant.
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between b6254a0 and 9fec81d.

📒 Files selected for processing (1)
  • .changeset/fast-horses-explode.md (1 hunks)

@wingkwong wingkwong changed the title fix(input): fixing the fullWidth functionality in input and select fix(theme): fullWidth in input and select Oct 3, 2024
@wingkwong wingkwong merged commit 781b855 into nextui-org:canary Oct 3, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - fullWidth prop of Select component does nothing
3 participants