Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input): ensure clear button is not focusable when disabled #3774

Merged
merged 8 commits into from
Sep 26, 2024
Merged

fix(input): ensure clear button is not focusable when disabled #3774

merged 8 commits into from
Sep 26, 2024

Commits on Sep 17, 2024

  1. fix(input): ensure clear button is not focusable when disabled

    @ryxxn
    ryxxn committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    b530806 View commit details
    Browse the repository at this point in the history

  2. test(input): add test to ensure clear button is not focusable when di… 

    …sabled
    @ryxxn
    ryxxn committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    99ce409 View commit details
    Browse the repository at this point in the history

  3. chore: add changeset for clear button focus fix when input is disabled

    @ryxxn
    ryxxn committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    2823aea View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. fix(input): update clear button to use button element

    @ryxxn
    ryxxn committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    4716c45 View commit details
    Browse the repository at this point in the history

  2. test(input): add focus test when disabled 

    and update tests for clear button using button element
    @ryxxn
    ryxxn committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    081c0e4 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2024

  1. test(input): replace querySelector with getByRole for clear button

    @ryxxn
    ryxxn committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    b3bd46a View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. fix(input): set tabIndex to -1 for clear button

    @ryxxn
    ryxxn committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    84fd6b4 View commit details
    Browse the repository at this point in the history

  2. test(input): ensure clear button is not focusable

    @ryxxn
    ryxxn committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    10b4a1d View commit details
    Browse the repository at this point in the history