-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(autocomplete): popover should remain open after clicking clear button #3788
fix(autocomplete): popover should remain open after clicking clear button #3788
Conversation
🦋 Changeset detectedLatest commit: 6127840 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@abhinav700 is attempting to deploy a commit to the NextUI Inc Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe pull request introduces modifications to the Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! The behavior looks good.
Could you add some tests?
@ryo-manba Sure, I will try to add some test cases |
…Button is clicked
@ryo-manba I have added the test cases. In the new test cases, I have not checked if the value is being cleared or not because that functionality is already covered in the previous test cases. |
packages/components/autocomplete/__tests__/autocomplete.test.tsx
Outdated
Show resolved
Hide resolved
packages/components/autocomplete/__tests__/autocomplete.test.tsx
Outdated
Show resolved
Hide resolved
@ryo-manba I have made the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for your contribution!
Closes #3783
📝 Description
Added
state.open()
so that dropdown does not close when clear button is clicked.based on this PR
💣 Is this a breaking change (Yes/No): No
Summary by CodeRabbit
Summary by CodeRabbit