Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autocomplete): popover should remain open after clicking clear button #3788

Merged
merged 6 commits into from
Sep 28, 2024

Conversation

abhinav700
Copy link
Contributor

@abhinav700 abhinav700 commented Sep 20, 2024

Closes #3783

📝 Description

Added state.open() so that dropdown does not close when clear button is clicked.
based on this PR

💣 Is this a breaking change (Yes/No): No

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features
    • Enhanced the autocomplete component to keep the dropdown open when the clear button is pressed, allowing for a smoother user interaction experience.

Copy link

changeset-bot bot commented Sep 20, 2024

🦋 Changeset detected

Latest commit: 6127840

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@nextui-org/autocomplete Patch
@nextui-org/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 20, 2024

@abhinav700 is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Sep 20, 2024

Walkthrough

The pull request introduces modifications to the @nextui-org/autocomplete package, specifically altering the behavior of the clear button within the autocomplete component. The changes ensure that the dropdown remains open when the clear button is pressed, allowing users to continue interacting with the dropdown seamlessly. The state.open() method is now invoked on the clear button's onPress event, while the state.close() method has been removed.

Changes

Files Change Summary
.changeset/dirty-moles-refuse.md Introduces updates to the clear button behavior in the autocomplete component, ensuring the dropdown remains open after clearing the input.
autocomplete.test.tsx Adds two test cases to verify that the autocomplete listbox remains open after clicking the clear button, for both standard and controlled components.

Assessment against linked issues

Objective Addressed Explanation
Autocomplete does not work when the clear button is hit (regression) (#3783)

Possibly related PRs

Suggested reviewers

  • jrgarciadev

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 046a9df and 6127840.

📒 Files selected for processing (1)
  • .changeset/dirty-moles-refuse.md (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .changeset/dirty-moles-refuse.md

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@abhinav700 abhinav700 changed the title fix: popover should remain open after clicking clear button fix(autocomplete): popover should remain open after clicking clear button Sep 20, 2024
@ryo-manba ryo-manba self-requested a review September 21, 2024 03:22
Copy link
Member

@ryo-manba ryo-manba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The behavior looks good.
Could you add some tests?

@abhinav700
Copy link
Contributor Author

@ryo-manba Sure, I will try to add some test cases

@abhinav700
Copy link
Contributor Author

abhinav700 commented Sep 21, 2024

@ryo-manba I have added the test cases.

In the new test cases, I have not checked if the value is being cleared or not because that functionality is already covered in the previous test cases.

@wingkwong wingkwong requested review from wingkwong and removed request for jrgarciadev September 25, 2024 02:06
@wingkwong wingkwong added this to the v2.5.0 milestone Sep 25, 2024
@abhinav700
Copy link
Contributor Author

@ryo-manba I have made the changes.

Copy link
Member

@ryo-manba ryo-manba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for your contribution!

@wingkwong wingkwong merged commit 2e82f16 into nextui-org:canary Sep 28, 2024
5 of 7 checks passed
This was referenced Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Autocomplete does not work when the clear button is hit (regression)
3 participants