fix(theme): support RTL for breadcrumbs

[ShrinidhiUpadhyaya]

Closes #2486

📝 Description

Added rotation for separator icon in RTL layout.

⛳️ Current behavior (updates)

🚀 New behavior

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

• New Features
  • Enhanced breadcrumb component with right-to-left language support for improved visual representation.
• Bug Fixes
  • Adjusted separator styling to accommodate right-to-left text direction.

[changeset-bot]

🦋 Changeset detected

Latest commit: 0372a10

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@nextui-org/theme	Patch
@nextui-org/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

@ShrinidhiUpadhyaya is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

Walkthrough

The changes in this pull request involve an update to the separator slot within the breadcrumbItem component located in the packages/core/theme/src/components/breadcrumbs.ts file. The modification enhances support for right-to-left (RTL) languages by adding a rotation style to the separator class, specifically changing it from "text-default-400 px-1" to "text-default-400 px-1 rtl:rotate-180". This adjustment improves the visual representation of the breadcrumbs in RTL contexts.

Changes

File Path	Change Summary
packages/core/theme/src/components/breadcrumbs.ts	Updated separator class for RTL support by adding rtl:rotate-180 style.

Assessment against linked issues

Objective	Addressed	Explanation
Improve RTL support in breadcrumbs (#2486)	✅

Possibly related PRs

• fix(components): improve RTL support for input component #2038: This PR improves RTL support for the input component, which is relevant as it also focuses on enhancing usability for right-to-left layouts.
• fix(components): improve RTL support for select component #2041: This PR enhances RTL support for the select component, aligning with the main PR's focus on improving visual representation for RTL languages.
• fix(components): improve RTL support for table component #2097: This PR improves RTL support for the table component, which shares the objective of enhancing usability in RTL contexts.
• fix(calendar): arrows changing order when html has dir="rtl" #3656: This PR addresses RTL navigation issues in the calendar component, which is related to the overall theme of improving RTL support across components.
• refactor(theme): replace the use of RTL-specific styles with logical properties #3868: This PR refactors the theme to replace RTL-specific styles with logical properties, which is directly related to the main PR's focus on enhancing RTL support in the breadcrumbItem component.

Suggested reviewers

• jrgarciadev
• wingkwong

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[wingkwong]

please add a changeset

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

.changeset/quick-geckos-punch.md (1)

1-5: LGTM! Consider enhancing the change description.

The changeset is correctly formatted and appropriately describes the patch for RTL support in the Breadcrumbs component. The issue reference (#2486) is correctly included.

Consider slightly expanding the change description for better clarity:

-separator icon RTL support in Breadcrumbs component (#2486)
+Add RTL support for separator icon in Breadcrumbs component (#2486)

This minor adjustment makes the purpose of the change more explicit.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 7175643 and 0372a10.

📒 Files selected for processing (1)

• .changeset/quick-geckos-punch.md (1 hunks)

🧰 Additional context used

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nextui-storybook-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 22, 2024 9:45am