Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(docs): default import -> named import #601

Closed
wants to merge 14 commits into from
Closed

refactor(docs): default import -> named import #601

wants to merge 14 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 5, 2022

Closes #579

📝 Description

Refactor import code in document

💣 Is this a breaking change (Yes/No):

No

@ghost ghost requested a review from jrgarciadev as a code owner July 5, 2022 21:40
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2022

Codecov Report

Merging #601 (8cccb06) into main (10c4c25) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #601   +/-   ##
=======================================
  Coverage   74.77%   74.77%           
=======================================
  Files         223      223           
  Lines        3501     3501           
  Branches     1105     1105           
=======================================
  Hits         2618     2618           
  Misses        868      868           
  Partials       15       15           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danielsimao
Copy link
Contributor

@TroyTae is this change related to React 18.0.0? Just out of curiosity.

@ghost
Copy link
Author

ghost commented Jul 6, 2022

@danielsimao
As I wrote here(#579), it's related to React 17!

@jrgarciadev
Copy link
Member

Hey @TroyTae sorry, could you please fix the conflicts?

@vercel
Copy link

vercel bot commented Aug 29, 2022

@TroyTae is attempting to deploy a commit to the NextUI Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Aug 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nextui-storybook ✅ Ready (Inspect) Visit Preview Aug 29, 2022 at 2:44PM (UTC)

@ghost
Copy link
Author

ghost commented Aug 29, 2022

@jrgarciadev Done!

@jrgarciadev
Copy link
Member

Hey @TroyTae thank you!, I forgot to mention to you that for it to work we have to modify the transformCode function https://github.com/nextui-org/nextui/blob/main/apps/docs/src/components/playground/utils.ts#L9-L42 which is a mini transpiler that I wrote to join sandpack with react-live,

I'm getting this error because of that:

Screen Shot 2022-08-29 at 09 43 09

@ghost
Copy link
Author

ghost commented Aug 29, 2022

@jrgarciadev Oops I'm so sorry
I'm just added react hooks into react-live scope

@ghost
Copy link
Author

ghost commented Oct 5, 2022

@jrgarciadev Are there some additional issues blocking of this?

@ghost ghost closed this by deleting the head repository Oct 19, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants