Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test suite #138

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Improve test suite #138

merged 1 commit into from
Jan 3, 2024

Conversation

mskelton
Copy link
Collaborator

Description

This updates the test suite to use a custom Jest matcher for better error messages and stack traces.

Additional context

image

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the Style Guide.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

@mskelton mskelton force-pushed the improve-test-runner branch from 01565db to cc5b88a Compare December 16, 2023 18:49
@mskelton mskelton requested a review from jrgarciadev December 16, 2023 19:18
@mskelton mskelton marked this pull request as ready for review December 16, 2023 19:18
jrgarciadev
jrgarciadev approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@jrgarciadev jrgarciadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! @mskelton thank you!

@jrgarciadev jrgarciadev merged commit 0ff1820 into main Jan 3, 2024
4 checks passed
@jrgarciadev jrgarciadev deleted the improve-test-runner branch January 3, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrgarciadev jrgarciadev jrgarciadev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mskelton @jrgarciadev