Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support false variants when using compoundSlots #83

Merged
merged 1 commit into from
Jul 25, 2023
Merged

fix: support false variants when using compoundSlots #83

merged 1 commit into from
Jul 25, 2023

Conversation

mskelton
Copy link
Collaborator

Fixes #74

Description

compoundSlots did not work properly when setting a boolean variant to false. This resolves that issue.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the Style Guide.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

@mskelton mskelton mentioned this pull request Jul 18, 2023
Closed
@jrgarciadev jrgarciadev merged commit 0fa67e3 into nextui-org:main Jul 25, 2023
@mskelton mskelton deleted the compound-slot-falsy branch July 26, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrgarciadev jrgarciadev jrgarciadev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compound Slots not working with variants
2 participants
@mskelton @jrgarciadev