Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

license dates #1437

Closed
sanbrock opened this issue Sep 26, 2024 · 9 comments
Closed

license dates #1437

sanbrock opened this issue Sep 26, 2024 · 9 comments
Assignees
Labels
Milestone

Comments

@sanbrock
Copy link
Contributor

Should not we use consistent license dates for all nxdl.xml files? Specifically 2008-2024 throughout

@sanbrock sanbrock converted this from a draft issue Sep 26, 2024
@prjemian
Copy link
Contributor

There are reasons why a copyright starting date may differ. Is this a problem?

I don't believe we should go and change this type of history.

@mkuehbach
Copy link
Contributor

Poten
https://reuse.software/

@phyy-nx
Copy link
Contributor

phyy-nx commented Sep 28, 2024

Discussion from NIAC: it's likely the different copyright statements arose either from the time in which the given file was created, or a copypaste from one file to another. The question is a) is it appropriate to have the copyright in each individual file at all, and b) if so, should they all be the same?

@tacaswell a) if all the files are part of the same work doesn't matter, but if they are separate works they do matter b) yes

Proposal, make all the copyright statements the same, and set the ranges to 2008-

(more research to be done)

@paulmillar
Copy link

The usual IANAL disclaimer applies, but I believe copyright year indicates when changes were made (and published).

The procedure (as I understand it) is that, each time a file is edited, the copyright date-range should be updated to include the current year. If the date already shows the current year then no change is needed.

For example, if a file states it is "copyright 2000--2023" then the first edit of 2024 should updated the copyright year to "2000--2024". Subsequent changes in 2024 would leave the date unchanged.

From this answer, the answer's author claims that intermittent (non-continuous) edits should be written as comma-separated list of date-ranges (where a date-range could be a single year). For example, a file created in 2020 and updated in 2024 should be written "copyright 2020,2024" and not "copyright 2020--2024".

To be honest, I've never seen copyright asserted using anything other than a single date-range ("2020--2024" in above example).

As an aside, it might be possible verify (and possibly update) the copyright date-range in files using information stored in git.

Back to Sander's suggestion: no, I don't believe we should have a consistent copyright date-range on all files because this would be inconsistent with (what I've seen as) common practice with other projects.

@prjemian
Copy link
Contributor

Every year, I have updated the final copyright year throughout the project. Most recently in #1355. See utils/update_copyright_date.py for details. This script does not touch the starting date.

@prjemian
Copy link
Contributor

Regarding the lack of gaps in the range, this script assures that NeXus asserts continuous copyright from starting date inclusive to the present.

@prjemian prjemian self-assigned this Sep 28, 2024
@prjemian prjemian added this to the NXDL 2025 milestone Sep 28, 2024
@yayahjb
Copy link
Contributor

yayahjb commented Sep 29, 2024 via email

@prjemian
Copy link
Contributor

prjemian commented Sep 29, 2024 via email

@phyy-nx phyy-nx self-assigned this Sep 29, 2024
@phyy-nx
Copy link
Contributor

phyy-nx commented Dec 18, 2024

Got some (non-official) copyright advice from some folks at my work. We are doing fine. To reiterate:

  • Our definitions have a copyright line like this one: "Copyright (C) 2014-2024 NeXus International Advisory Committee (NIAC)"
  • The first year is the date the file was created
  • The second year is the date of the most recent release
  • No need to go change all the definitions to the same Copyright line
  • Each release, we should update the second year
  • The second year is actually the start of the copyright period after the last significant change (which is our releases)

@phyy-nx phyy-nx closed this as completed Dec 18, 2024
@github-project-automation github-project-automation bot moved this from To finish after the meeting to Done in NIAC 2024 project Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

6 participants