Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review: NXmirror #45

Closed
stuartcampbell opened this issue May 5, 2014 · 7 comments
Closed

Review: NXmirror #45

stuartcampbell opened this issue May 5, 2014 · 7 comments
Labels
bug definitions
Milestone
NXDL 2020.1

Comments

@stuartcampbell
Copy link
Member

Original reporter: prjemian

  • incident_angle, bend_angle_x, bend_angle_y, substrate_thickness needs units[[BR]]
  • reflectivity, m_value, *_roughness need to be NX_UNITLESS
@stuartcampbell
Copy link
Member Author

Original reporter: prjemian

  • *_roughness for mirrors is usually expressed in Angstroms RMS, (units of NX_LENGTH or we create NX_ROUGHNESS to accept the RMS part)

@stuartcampbell
Copy link
Member Author

Original reporter: sic

(In [432]) Updated m-value description. refs #45

@stuartcampbell
Copy link
Member Author

Original reporter: prjemian

compare this definition with what SHADOW does

@stuartcampbell
Copy link
Member Author

Original reporter: prjemian

multi-layer mirrors need consideration either here or as a new class

@stuartcampbell
Copy link
Member Author

Original reporter: prjemian

suggestion from 2010 HDF5 workshop at DESY is to refer to SHADOW (common ray tracing code for X-ray instruments) for comparison

Rainer Gehrke, DESY, to communicate review comments to NeXus tech developers or NIAC

@stuartcampbell
Copy link
Member Author

Original reporter: prjemian

see related ticket #152

@stuartcampbell stuartcampbell mentioned this issue May 5, 2014
Closed
@zjttoefs
Copy link
Contributor

zjttoefs commented Sep 9, 2015

The base class has a number of TODO items. The main thing being lack of proper documentation. Someone with an interest in optics should have a look.

Quite a few of the fields requested in addition could be removed from the TODO list, as they to not appear to have been put in by people in practise so far.

@prjemian prjemian modified the milestones: later, NXDL 3.2 Jan 17, 2017
@zjttoefs zjttoefs closed this as completed May 8, 2018
@prjemian prjemian modified the milestones: later, NXDL 2019.10 May 20, 2019
@prjemian prjemian mentioned this issue Jan 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug definitions
Projects
None yet
Milestone
NXDL 2020.1
Development

No branches or pull requests
3 participants
@stuartcampbell @zjttoefs @prjemian