Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create structure to incorporate PDB definitions into NeXus #553

Closed
yayahjb opened this issue Apr 5, 2017 · 6 comments
Closed

Create structure to incorporate PDB definitions into NeXus #553

yayahjb opened this issue Apr 5, 2017 · 6 comments
Assignees
Milestone

Comments

@yayahjb
Copy link
Contributor

yayahjb commented Apr 5, 2017

As per March 2017 HDRMX meeting in Lund, create a structure to incorporate PDB definitions into NeXus, possibly as a new NXpdb base class.

@zjttoefs
Copy link
Contributor

Herbert will discuss at the ACA meeting 26th May. If there could be some idea of how we want to implement that, that would be good.

@prjemian prjemian modified the milestone: NXDL 3.4 Jun 30, 2017
@prjemian
Copy link
Contributor

@yayahjb : bump

@prjemian prjemian assigned yayahjb and unassigned prjemian Jan 30, 2018
@mkoennecke
Copy link
Contributor

I had a look at this. Looks good for the time being. But I would like to see an example where a more completed PDB file has been mapped.

Then I have a suggestion: Currently the NXpdb class s used for the main entry and for all groups underneath it. I suggest to name the top level NXpdb_container in order to mark it more clearly as a the root of a hierarchy following NeXus PDB conventions.

@zjttoefs zjttoefs modified the milestones: NXDL 2018.4, NXDL 2018.10 May 2, 2018
@prjemian prjemian modified the milestones: NXDL 2018.8, NXDL 2019.1 Sep 5, 2018
@zjttoefs
Copy link
Contributor

zjttoefs commented Sep 7, 2018

We are waiting for the conversion tool that codifies the PDB <-> NeXus translation for this to be merged/closed. (#614)

@yayahjb
Copy link
Contributor Author

yayahjb commented Oct 29, 2018

As per NIAC 2018, have added example files, in nexusformat/exampledata/nxpdb, produced using the conversion tool in CBFlib. Will extract the conversion tool, package it and put it in nexusformat by next week.

prjemian added a commit that referenced this issue May 14, 2019
@prjemian
Copy link
Contributor

2020 Code Camp decide to close this issue as resolved by PR #614.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants