-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need underload value for detectors #656
Labels
Comments
phyy-nx
added a commit
to cctbx/dxtbx
that referenced
this issue
Apr 16, 2019
AFAIK undefined_value isn't in any existing nexus files. See nexusformat/definitions#656 for the proposed replacement.
Approved during telco |
phyy-nx
added a commit
to cctbx/dxtbx
that referenced
this issue
Apr 24, 2019
phyy-nx
added a commit
to cctbx/cctbx_project
that referenced
this issue
Apr 24, 2019
alyubimov
pushed a commit
to cctbx/cctbx_project
that referenced
this issue
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
NXdetector specifies the saturation value for the detector:
The corresponding value, underload, is missing. Granted, in pixel_mask, bit 2 is classified as under responding. However, having a separate underload value available means a global number can be specified.
Note that in ImageCIF, underload is not explicitly defined, but it does define the parameters overload and undefined_value:
https://www.iucr.org/__data/iucr/cifdic_html/2/cif_img.dic/Carray_intensities.html
https://www.iucr.org/__data/iucr/cifdic_html/2/cif_img.dic/Iarray_intensities.overload.html
https://www.iucr.org/__data/iucr/cifdic_html/2/cif_img.dic/Iarray_intensities.undefined_value.html
So we could use undefined_value, but to me that does not imply pixels less than this value should not be included. If I had my druthers we would use trusted_min and trusted_max since those are very clear. However, since we already have saturation_value, I'd propose underload_value to match it.
Proposal:
The choice of language here matches the implied inequalities for saturation_value and matches the implementation in DIALS for generating a mask from a trusted range (min and max):
https://github.com/dials/dials/blob/master/util/masking.py#L168
mask = (imd > low) & (imd < high)
However, I think we could be more explicit in both saturation_value and underload_value by adding this sentence to both entries:
The text was updated successfully, but these errors were encountered: