Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some unit tests fail since flexible names are UPPER case #714

Closed
prjemian opened this issue Jan 22, 2020 · 1 comment · Fixed by #715
Closed

some unit tests fail since flexible names are UPPER case #714

prjemian opened this issue Jan 22, 2020 · 1 comment · Fixed by #715
Assignees
Labels
Milestone

Comments

@prjemian
Copy link
Contributor

some unit tests fail since #562:

======================================================================

FAIL: test_application_definition_NXcanSAS (test_nxdl2rst.Issue_524_Clarify_Optional_or_Required)

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/home/travis/build/nexusformat/definitions/utils/test_nxdl2rst.py", line 82, in test_application_definition_NXcanSAS

    self.apply_tests('applications', 'NXcanSAS', expected_lines)

  File "/home/travis/build/nexusformat/definitions/utils/test_nxdl2rst.py", line 94, in apply_tests

    self.assertTrue(line.strip() in printed_lines, line.strip())

AssertionError: **(entry)**: (required) :ref:`NXentry`

======================================================================

FAIL: test_base_class_NXentry (test_nxdl2rst.Issue_524_Clarify_Optional_or_Required)

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/home/travis/build/nexusformat/definitions/utils/test_nxdl2rst.py", line 48, in test_base_class_NXentry

    self.apply_tests('base_classes', 'NXentry', expected_lines)

  File "/home/travis/build/nexusformat/definitions/utils/test_nxdl2rst.py", line 94, in apply_tests

    self.assertTrue(line.strip() in printed_lines, line.strip())

AssertionError: **(data)**: (optional) :ref:`NXdata`
@prjemian prjemian added the bug label Jan 22, 2020
@prjemian prjemian added this to the NXDL 2020.1 milestone Jan 22, 2020
@prjemian prjemian self-assigned this Jan 22, 2020
@prjemian
Copy link
Contributor Author

They fail because the expected names should now be upper case. Here are the current expected names that fail:

        **(entry)**: (required) :ref:`NXentry`
        **(data)**: (required) :ref:`NXdata`
        **(data)**: (optional) :ref:`NXdata`
        **(sample)**: (optional) :ref:`NXsample`
        **(instrument)**: (optional) :ref:`NXinstrument`
        **(note)**: (optional) :ref:`NXnote`
        **(process)**: (optional) :ref:`NXprocess`
        **(source)**: (optional) :ref:`NXsource`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant