Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove definitions@version attribute #623

Merged
merged 5 commits into from
May 15, 2018
Merged

remove definitions@version attribute #623

merged 5 commits into from
May 15, 2018

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian commented May 11, 2018 •
edited
Loading

fixes #616

next steps:

@prjemian prjemian added this to the NXDL 2018.5 milestone May 11, 2018
@prjemian prjemian self-assigned this May 11, 2018
@prjemian prjemian requested a review from zjttoefs May 11, 2018 17:26
prjemian referenced this pull request in jacobfilik/definitions May 11, 2018
@jacobfilik
Definitions of NXexperiment and NXexperimentdata
68e6946
@prjemian
Copy link
Contributor Author

squash merge this one (see the drop down on the green "Merge pull request" button)

@prjemian prjemian added the telco label May 15, 2018
zjttoefs
zjttoefs approved these changes May 15, 2018
View reviewed changes
Copy link
Contributor

@zjttoefs zjttoefs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@zjttoefs zjttoefs merged commit a3f08b7 into master May 15, 2018
@zjttoefs zjttoefs deleted the version_attribute_616 branch May 15, 2018 14:42
@prjemian prjemian mentioned this pull request May 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zjttoefs zjttoefs zjttoefs approved these changes

Assignees

@prjemian prjemian

Labels
definitions high priority nxdl-syntax task telco
Projects
None yet
Milestone
NXDL 2018.5
Development

Successfully merging this pull request may close these issues.

remove version attribute from NXDL Schema
2 participants
@prjemian @zjttoefs