-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nxquadric 1 #627
Nxquadric 1 #627
Conversation
NXDL description XML files for the three NXquadric and constructive solid geometry classes.
Delete the dummy file
That build failed, please fix the tags. |
Please remove the example data from this PR. You are encouraged to make a companion PR in the NeXus repository for example data: https://github.com/nexusformat/exampledata You may need to create a subdirectory path for this. Try to follow the apparent practice. Add a README.md with the example data to describe the file(s) such as what it is and whether or not the files are compliant with the NeXus standard (version ____). |
The failure is in the XML:
|
Add the field close tag and rename the 'type' field to 'surface_type'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commented previously, changes made, passes travis-ci validation checks, ok. Thanks!
Comments by anyone else? Shall we merge? Marking for next telco. |
Proposed NXquadric and NXcsg classes to allow the definition of constructive solid geometry from quadric surfaces.