Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define diffractometer in NXinstrument -- issue 632 #635

Merged
merged 3 commits into from
May 14, 2019

Conversation

prjemian
Copy link
Contributor

@vasole : resolves issue #632

@prjemian prjemian added this to the NXDL 2019.1 milestone Oct 26, 2018
@prjemian prjemian added NIAC should review The NIAC should review/discuss and removed NIAC should review The NIAC should review/discuss labels Oct 26, 2018
@prjemian prjemian requested review from benajamin and zjttoefs and removed request for stuartcampbell October 26, 2018 15:54
@prjemian prjemian added the NIAC has requested The NIAC has requested this issue to be considered label Oct 26, 2018
mention allowed use for sample table and stages
@prjemian
Copy link
Contributor Author

prjemian commented Apr 2, 2019

@benajamin If you approve changes, I will Squash and merge this PR.

@prjemian
Copy link
Contributor Author

@benajamin : I'll merge tomorrow unless I hear objection.

@prjemian prjemian merged commit 1454aa2 into master May 14, 2019
@stuartcampbell stuartcampbell deleted the diffractometer_632 branch September 11, 2019 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
definitions NIAC has requested The NIAC has requested this issue to be considered
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants