Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added documentation for variants to datarules.rst #666

Merged
merged 2 commits into from
Jan 22, 2020
Merged

Added documentation for variants to datarules.rst #666

merged 2 commits into from
Jan 22, 2020

Conversation

mkoennecke
Copy link
Contributor

Refs #645

As discussed, documentation for variants as recovered from NIAC Telcos and based on a decision from NIAC 2014.

prjemian
prjemian approved these changes Jul 28, 2019
View reviewed changes
Copy link
Contributor

@prjemian prjemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this.

@prjemian prjemian added this to the NXDL 2019.10 milestone Jul 28, 2019
@prjemian
Copy link
Contributor

Will merge after August 31 if there are no objections

benajamin
benajamin requested changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@benajamin benajamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This text is the opposite of the requested meaning, which was that "the actual field with the NeXus name will always hold the best value".

@benajamin
Corrected text for Variants section
2c89d95 
Corrected text to match match comment #645 (comment) in issue #645
@benajamin benajamin self-requested a review January 21, 2020 22:21
@prjemian prjemian merged commit 2f09650 into master Jan 22, 2020
@prjemian prjemian deleted the variants branch January 22, 2020 00:10
@benajamin benajamin mentioned this pull request Jan 22, 2020
Closed
@prjemian prjemian mentioned this pull request Jan 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benajamin benajamin benajamin approved these changes

@prjemian prjemian prjemian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
NXDL 2020.1
Development

Successfully merging this pull request may close these issues.
3 participants
@mkoennecke @prjemian @benajamin