Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additional NXdetector documentation #679

Merged
merged 3 commits into from
Aug 25, 2019
Merged

Conversation

prjemian
Copy link
Contributor

Contributions from Eugen Wintersberger for issue #412

@prjemian prjemian added this to the NXDL 2019.10 milestone Aug 25, 2019
@prjemian prjemian self-assigned this Aug 25, 2019
@prjemian prjemian mentioned this pull request Aug 25, 2019
@prjemian
Copy link
Contributor Author

Note: detectors.txt (BTW: in reST format) is intended for include into design.rst just before the _Size-Shape label:

.. include:: detectors.txt

..  
    .. _Size-Shape:
    

@prjemian
Copy link
Contributor Author

Can take the SVG drawings over the PNG ones since SVG is now supported in modern browsers. Take both but probably drop PNG.

@prjemian
Copy link
Contributor Author

pushing all this new content from Eugen into a _static/412-detector-docs folder for now, just a placeholder

@prjemian
Copy link
Contributor Author

For the record, not including any of the configuration for cmake.

@prjemian
Copy link
Contributor Author

Once CI passes, then I'll re-close #412. The point of this PR is to merge the content provided by Eugen Wintersberger. The documentation for NXdetector remains unchanged by this PR.

@prjemian prjemian marked this pull request as ready for review August 25, 2019 16:47
@prjemian prjemian merged commit cb128a9 into master Aug 25, 2019
@prjemian prjemian deleted the 412_NDdetector-drawings branch August 25, 2019 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant