Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change NXparameter to NXparameters #694

Merged
merged 1 commit into from
Nov 20, 2019
Merged

change NXparameter to NXparameters #694

merged 1 commit into from
Nov 20, 2019

Conversation

jkotan
Copy link
Contributor

@jkotan jkotan commented Nov 20, 2019

In order to be compatible with the NXparameters base class I've changed NXparameter to NXparameters

@prjemian prjemian self-requested a review November 20, 2019 21:19
@prjemian prjemian self-assigned this Nov 20, 2019
prjemian
prjemian approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@prjemian prjemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thanks for this.

@prjemian prjemian merged commit b011858 into nexusformat:master Nov 20, 2019
@prjemian prjemian mentioned this pull request Jan 26, 2020
Merged
prjemian pushed a commit that referenced this pull request Mar 4, 2020
@zjttoefs
refs #694
935afe4 
drop the "the" and remove some missed instances referencing the sample
and using the source instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prjemian prjemian prjemian approved these changes

Assignees

@prjemian prjemian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkotan @prjemian