NXdetector: Add virtual_pixel_correction_applied

[soph-dec]

We use virtual pixels to account for the space in between chips. For that, the edge pixels of the chips are extended into the gaps, creating more counts on those edges.The virtual pixel correction distributes these counts over the logical pixels.

[PeterC-DLS]

The description in the doc is too succinct. The concept and context of virtual pixels is missing: you need to explain what/where these virtual pixels are, what this correction is and how this relates to gap pixels indicated in pixel_mask.

[soph-dec]

I see, I'll do that! I was keeping it short so it would match the descriptions of other fields, like flatfield_correction_applied or countrate_correction_applied.

[PeterC-DLS]

That's a clear explanation. So the consequence of this flag being true is that all pixels labelled as a virtual pixel in the pixel_mask no longer have to be ignored.

[rayosborn]

This looks interesting. Is this for a particular brand of detector and is the correction performed by software the manufacturer supplies?

[kalcutter]

@rayosborn The majority of DECTRIS detectors have virtual pixels. In this case, the interpolation is performed as a correction by the supplied software. I believe there are also some other manufacturers that employ virtual pixels in their detectors.

[kalcutter]

Do people see an issue using "correction" in the name? I suppose if the hardware did virtual pixel interpolation directly, it wouldn't strictly be a "correction". The field could also be called virtual_pixel_interpolation?

[soph-dec]

What is needed for this to get approved?

[phyy-nx]

Agree that virtual_pixel_interpolation_applied is a better name. Consensus in NIAC telco is after that change is made this PR is good to go.

[yayahjb]

Looks good. -- Herbert

[benajamin]

@phyy-nx Merging this branch was approved by NIAC vote (nexusformat/NIAC#94). Is there a good reason why it hasn't been done yet?

[soph-dec]

The merge conflicts have been resolved now.

[phyy-nx]

@benajamin thanks for the reminder and @soph-dec thanks for the fixes. Merging!