Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more items that should not be added to repo #948

Closed
wants to merge 1 commit into from

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian commented Dec 8, 2021

Today, I found these uncommitted items in my local clone of the definitions repository:

(bluesky_2022_1) prjemian@zap:~/.../NeXus/definitions$ git status
On branch more-ignore-items
Untracked files:
  (use "git add <file>..." to include in what will be committed)
	manual/source/classes/applications/canSAS/
	manual/source/classes/applications/index.rst
	manual/source/classes/base_classes/index.rst
	manual/source/classes/contributed_definitions/container/
	manual/source/classes/contributed_definitions/index.rst

@prjemian prjemian added the task label Dec 8, 2021
@prjemian prjemian added this to the NXDL 2021.10 milestone Dec 8, 2021
@prjemian prjemian requested a review from PeterC-DLS December 8, 2021 16:26
@prjemian prjemian self-assigned this Dec 8, 2021
@prjemian
Copy link
Contributor Author

prjemian commented Dec 8, 2021

Since these look like work-product of a build of the documentation, they should be added to the /.gitignore file. This PR does that:

(bluesky_2022_1) prjemian@zap:~/.../NeXus/definitions$ git status
On branch more-ignore-items
Your branch is up to date with 'origin/more-ignore-items'.

nothing to commit, working tree clean

@prjemian
Copy link
Contributor Author

prjemian commented Dec 8, 2021

The workflow is failing, even when restarted. This error is reported:

AttributeError: 'FileNotFoundError' object has no attribute 'read'

Same is found when trying locally now (to create a custom conda environment to apply syntax checks, same as worflow). The problem seems to be:

- pip:
- -r file:requirements.txt

.gitignore Show resolved Hide resolved
@prjemian
Copy link
Contributor Author

prjemian commented Dec 8, 2021

What started as a quick and simple change has escalated into this chain of issues to be resolved (in order): #950, #949, #946.

Closing this PR and deleting the branch to start over. Later. Placement in the TODO column of the project page has been adjusted.

@prjemian prjemian closed this Dec 8, 2021
@prjemian prjemian deleted the more-ignore-items branch December 8, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants