update PSMN configuration to keep up with cluster changes #788
+26
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfy133
approved these changes
Nov 5, 2024
pontus
reviewed
Nov 5, 2024
conf/psmn.config
Outdated
Comment on lines
16
to
20
| resourceLimits = [ | ||
| memory: 370.GB, | ||
| cpus: 32, | ||
| time: 96.h | ||
| ] |
There was a problem hiding this comment.
Was this removal intended? Seems like you'd want to keep resourceLimits around.
There was a problem hiding this comment.
Using clusterOptions to select partition is not wrong, but one could consider queue instead to manage those needing to override clusterOptions.
There was a problem hiding this comment.
Oops, I missed that - yes the resource limits definitely should be included!
There was a problem hiding this comment.
Thank you for the comment, so I can replace :
clusterOptions = "--partition=E5,Lake"
by :
queue = "E5,Lake"
with slurm ?
pontus
approved these changes
Nov 5, 2024
|
Hello, I applied all the recommended modifications, please tell me if there is anything else I should modify. Best, |
jfy133
approved these changes
Nov 13, 2024
|
You're good to merge @l-modolo ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: psmn
about: update PSMN configuration to keep up with cluster changes