Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove profile aws_tower #50

Merged
merged 7 commits into from
Jun 28, 2023
Merged

remove profile aws_tower #50

merged 7 commits into from
Jun 28, 2023

Conversation

mirpedrol
Copy link
Member

@mirpedrol mirpedrol commented Jun 28, 2023 •
edited
Loading

AWS full tests are failing.
Profile aws_tower was removed in nf-core/tools v2.9 nf-core/tools#2287 and https://github.com/nf-core/tools/pull/2288/files
This will hopefuly make tests pass

In addition, remove all quay.io from all moduels, set the registry defaults in nextflow.configoutside of profiles and update nextflow version.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/crisprseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Jun 28, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit dd29c46

+| ✅ 156 tests passed       |+
#| ❔  17 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: '2.0.0'
  • pipeline_todos - TODO string in README.md: If applicable, make list of people who have also contributed
  • pipeline_todos - TODO string in WorkflowMain.groovy: Add Zenodo DOI for pipeline after first release
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-06-28 14:38:43

@mirpedrol mirpedrol merged commit 956a82e into nf-core:dev Jun 28, 2023
@mirpedrol mirpedrol deleted the fix-full-tests-tower branch June 28, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurenceKuhl LaurenceKuhl LaurenceKuhl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mirpedrol @LaurenceKuhl