-
Notifications
You must be signed in to change notification settings - Fork 3
Use templates for R scripts and use subworkflow for fitness calculation #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.1.2. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
mashehu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't look into the R code, just general things
| @@ -1,3 +1,5 @@ | |||
| #!/usr/bin/env Rscript | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't forget to add a license statement to all your custom scripts
|
|
||
| # Function to split a DNA sequence into codons (triplets) | ||
| split_into_codons <- function(seq) { | ||
| # WICHTIG: doppeltes escaping für perl regex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # WICHTIG: doppeltes escaping für perl regex | |
| # Important: double escaping for perl regex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some more German to be replaced in other places
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to have so much white-space I think
| # [6] BiocGenerics_0.54.0 generics_0.1.4 | ||
| # | ||
| # loaded via a namespace (and not attached): | ||
| # [1] httr_1.4.7 compiler_4.5.1 R6_2.6.1 tools_4.5.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure you want to hard code these like this?
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).