Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document correct RNAseq matrix usage #200

Merged
merged 4 commits into from
Nov 20, 2023
Merged

Document correct RNAseq matrix usage #200

merged 4 commits into from
Nov 20, 2023

Conversation

pinin4fjords
Copy link
Member

Document the correct rnaseq matrices to use, referencing tximport documentation.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/differentialabundance branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@pinin4fjords pinin4fjords changed the base branch from master to dev November 20, 2023 09:58
@github-actions GitHub Actions
Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @pinin4fjords,

It looks like this pull-request is has been made against the nf-core/differentialabundance master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the nf-core/differentialabundance dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@pinin4fjords pinin4fjords changed the title Rnaseq matrix docs Document correct RNAseq matrix usage Nov 20, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 90eb2c6

+| ✅ 160 tests passed       |+

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-11-20 13:46:51

WackerO
WackerO approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@WackerO WackerO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pinin4fjords pinin4fjords merged commit bba14c3 into dev Nov 20, 2023
14 checks passed
@pinin4fjords pinin4fjords deleted the rnaseq_matrix_docs branch November 20, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WackerO WackerO WackerO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pinin4fjords @WackerO