Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address v1.1.0 pre-release feedback (subway map fixes) #82

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

pinin4fjords
Copy link
Member

This PR is collecting changes to address pre-release feedback in #78.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/differentialabundance branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@pinin4fjords pinin4fjords marked this pull request as draft February 23, 2023 11:01
@pinin4fjords pinin4fjords changed the title Subway map tweaks Address v1.1.0 pre-release feedback Feb 23, 2023
@github-actions
Copy link

github-actions bot commented Feb 23, 2023

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 367fc56

+| ✅ 157 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-02-23 22:29:38

@pinin4fjords pinin4fjords marked this pull request as ready for review February 23, 2023 22:12
@pinin4fjords pinin4fjords changed the title Address v1.1.0 pre-release feedback Address v1.1.0 pre-release feedback (subway map fixes) Feb 23, 2023
@pinin4fjords
Copy link
Member Author

Thanks @mashehu

@pinin4fjords pinin4fjords merged commit f1e2f43 into nf-core:dev Feb 24, 2023
@pinin4fjords pinin4fjords deleted the v1.1.0_review branch February 24, 2023 08:54
@pinin4fjords pinin4fjords mentioned this pull request Feb 24, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants