Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix external tools import container #218

Closed
wants to merge 0 commits into from
Closed

Conversation

jonasscheid
Copy link
Contributor

@jonasscheid jonasscheid commented Nov 2, 2023

This PR is a quick fix for small bug that has been introduced with the new template update. Quay.io is now the standard container registry, but for EXTERNAL_TOOLS_IMPORT biocontainers/biocontainers:v1.2.0_cv1 is used. If docker.io is specified it takes precedence.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/epitopeprediction branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link

github-actions bot commented Nov 2, 2023

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 3d5720f

+| ✅ 160 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in WorkflowEpitopeprediction.groovy: Optionally add in-text citation tools to this list.

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-11-02 21:16:28

@christopher-mohr
Copy link
Collaborator

Thanks for the fix! Could you add the change to a clean branch? (see list of commits)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants