Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fred2 from version 2.0.6 to 2.0.7 #47

Merged
merged 2 commits into from
Aug 26, 2020

Conversation

skrakau
Copy link
Member

@skrakau skrakau commented Aug 25, 2020

Update Fred2.

Maybe we can improve the changelog in another PR.

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/epitopeprediction branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/epitopeprediction/tree/master/.github/CONTRIBUTING.md

@skrakau
Copy link
Member Author

skrakau commented Aug 25, 2020

The CI failed because 1) #39 should have waited until Fred2 was updated to 2.0.7 (thought we updated this already) and 2) just realised that I only added the mouse alleles to methods in ANN.py, but not to syfpeithi in PSSM.py. Thus this should be updated in Fred2, and for this pipeline for now the test_peptides_h2 should be run using MHCNuggets (or MHCFlurry)

Copy link
Collaborator

@christopher-mohr christopher-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @skrakau! Currently there are not mouse PSSMs for Syfpeithi in FRED2, therefore we should make sure that only mhcflurry and mhcnuggets is used with mouse alleles (can be done in a separate PR). Could you just change the test accordingly in this PR please? I will take care about the changelog with the template merge.

@skrakau
Copy link
Member Author

skrakau commented Aug 26, 2020

Ah forgot, makes sense then.

@christopher-mohr
Copy link
Collaborator

The test will be adapted in a separate PR.

@christopher-mohr christopher-mohr merged commit e616493 into nf-core:dev Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants