Skip to content

Commit

Permalink
Fixup for PR #253
Browse files Browse the repository at this point in the history
  • Loading branch information
adamrtalbot committed Jan 29, 2024
1 parent 8d3a0c5 commit 74fdcaa
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 14 deletions.
14 changes: 0 additions & 14 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -97,20 +97,6 @@ jobs:
run: |
echo ${{ steps.list.outputs.tags }}
# define_nxf_versions:
# name: Choose nextflow versions to test against depending on target branch
# runs-on: ubuntu-latest
# outputs:
# matrix: ${{ steps.nxf_versions.outputs.matrix }}
# steps:
# - id: nxf_versions
# run: |
# if [[ "${{ github.event_name }}" == "pull_request" && "${{ github.base_ref }}" == "dev" && "${{ matrix.NXF_VER }}" != "latest-everything" ]]; then
# echo matrix='["latest-everything"]' | tee -a $GITHUB_OUTPUT
# else
# echo matrix='["latest-everything", "23.04.0"]' | tee -a $GITHUB_OUTPUT
# fi

test:
name: ${{ matrix.tags }} ${{ matrix.profile }} NF-${{ matrix.NXF_VER }}
needs: [changes]
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ Thank you to everyone else that has contributed by reporting bugs, enhancements
- [PR #246](https://github.com/nf-core/fetchngs/pull/246) - Handle dark/light mode for logo in GitHub README properly
- [PR #248](https://github.com/nf-core/fetchngs/pull/248) - Update pipeline level test data path to use mirror on s3
- [PR #249](https://github.com/nf-core/fetchngs/pull/249) - Update modules which includes absolute paths for test data, making module level test compatible within the pipeline.
- [PR #253](https://github.com/nf-core/fetchngs/pull/253) - Add implicit tags in nf-test files for simpler testing strategy

### Software dependencies

Expand Down

0 comments on commit 74fdcaa

Please sign in to comment.