Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change container for sra_ids_to_runinfo.nf process #14

Merged
merged 12 commits into from
Jun 22, 2021
Merged

Change container for sra_ids_to_runinfo.nf process #14

merged 12 commits into from
Jun 22, 2021

Conversation

drpatelh
Copy link
Member

@drpatelh drpatelh commented Jun 21, 2021 •
edited
Loading

Closes #12

  • Update pipeline with current DSL2 template
  • Add --sample_mapping_fields parameter to create a separate mappings.tsv and multiqc_config.yml file with selected fields that can be used to rename samples in general and in MultiQC

@github-actions
Copy link

github-actions bot commented Jun 21, 2021 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 721621f

+| ✅ 105 tests passed       |+
#| ❔  18 tests were ignored |#
!| ❗  28 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: environment.yml
  • files_exist - File not found: Dockerfile
  • nextflow_config - Config variable not found: process.container
  • nextflow_config - Config manifest.version should end in dev: '1.1'
  • params_used - Config variable not found in main.nf: params.input
  • params_used - Config variable not found in main.nf: params.nf_core_pipeline
  • params_used - Config variable not found in main.nf: params.ena_metadata_fields
  • params_used - Config variable not found in main.nf: params.sample_mapping_fields
  • params_used - Config variable not found in main.nf: params.skip_fastq_download
  • params_used - Config variable not found in main.nf: params.outdir
  • params_used - Config variable not found in main.nf: params.tracedir
  • params_used - Config variable not found in main.nf: params.publish_dir_mode
  • params_used - Config variable not found in main.nf: params.email
  • params_used - Config variable not found in main.nf: params.email_on_fail
  • params_used - Config variable not found in main.nf: params.plaintext_email
  • params_used - Config variable not found in main.nf: params.monochrome_logs
  • params_used - Config variable not found in main.nf: params.help
  • params_used - Config variable not found in main.nf: params.validate_params
  • params_used - Config variable not found in main.nf: params.enable_conda
  • params_used - Config variable not found in main.nf: params.singularity_pull_docker_container
  • params_used - Config variable not found in main.nf: params.hostnames
  • params_used - Config variable not found in main.nf: params.config_profile_description
  • params_used - Config variable not found in main.nf: params.config_profile_contact
  • params_used - Config variable not found in main.nf: params.config_profile_url
  • params_used - Config variable not found in main.nf: params.max_memory
  • params_used - Config variable not found in main.nf: params.max_cpus
  • params_used - Config variable not found in main.nf: params.max_time
  • readme - README did not have a Nextflow minimum version badge.

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 1.14
  • Run at 2021-06-21 20:21:00

@drpatelh drpatelh requested a review from JoseEspinosa June 21, 2021 21:21
JoseEspinosa
JoseEspinosa approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

modules/local/sra_ids_to_runinfo.nf
@@ -10,11 +10,11 @@ process SRA_IDS_TO_RUNINFO {
mode: params.publish_dir_mode,
saveAs: { filename -> saveFiles(filename:filename, options:params.options, publish_dir:getSoftwareName(task.process), meta:[:], publish_by_meta:[]) }

conda (params.enable_conda ? "conda-forge::requests=2.24.0" : null)
conda (params.enable_conda ? "conda-forge::sed=4.7" : null)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these the same containers (conda vs. biocontainers) ? Couldn't we use the same container as in the multiqc process (quay.io/biocontainers/python:3.8.3)?
I guess that the answers is not but... 😜

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, unfortunately not because it doesn't have requests installed 😏

@drpatelh drpatelh merged commit 3e06f50 into nf-core:dev Jun 22, 2021
@drpatelh drpatelh mentioned this pull request Jun 22, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoseEspinosa JoseEspinosa JoseEspinosa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drpatelh @JoseEspinosa