Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Per module/subworkflow tags.yml file #212

Merged
merged 6 commits into from
Oct 10, 2023
Merged

Per module/subworkflow tags.yml file #212

merged 6 commits into from
Oct 10, 2023

Conversation

adamrtalbot
Copy link
Contributor

@adamrtalbot adamrtalbot commented Oct 10, 2023 •
edited
Loading

Changes:

  • Add separate tags.yml files for all modules and subworkflows that featured in the original tags.yml file.
  • Removes old tags.yml file
  • Adds github action to combine all tags.yml files for pattern matching using cat (tried YQ, string parsing errors).

@adamrtalbot
Per module/subworkflow tags.yml file
538cc23 
Changes:
- Add separate tags.yml files for all modules and subworkflows that featured in the original tags.yml file.
- Removes old tags.yml file
- Adds github action to combine all tags.yml files for pattern matching using yq
@github-actions
Copy link

github-actions bot commented Oct 10, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 051588c

+| ✅ 143 tests passed       |+
#| ❔  11 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: conf/igenomes.config
  • files_exist - File is ignored: conf/modules.config
  • files_exist - File is ignored: lib/WorkflowFetchngs.groovy
  • files_unchanged - File ignored due to lint config: .gitattributes
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml
  • actions_ci - actions_ci
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/fetchngs/fetchngs/.github/workflows/awstest.yml

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-10-10 14:22:48

@maxulysse
Copy link
Member

don't we have too many tests triggered?

@adamrtalbot
Copy link
Contributor Author

@maxulysse suggested recursively going through the main.nf files and determining which files to test from the main.nf import statements. A good idea but this is a solution for now instead of the best solution.

@adamrtalbot
Copy link
Contributor Author

don't we have too many tests triggered?

I think every test should fire with this PR because we have changed every single folder.

@adamrtalbot
Copy link
Contributor Author

This one should probably be squashed when merging.

@maxulysse
Copy link
Member

don't we have too many tests triggered?

I think every test should fire with this PR because we have changed every single folder.

of course 🤦

@adamrtalbot
Copy link
Contributor Author

@maxulysse shall we merge with failing tests? They're all curl limits so far. We could keep retrying overnight.

@maxulysse maxulysse merged commit 7c54d4f into refactor Oct 10, 2023
20 of 35 checks passed
@maxulysse maxulysse deleted the separate_tags_into_individual_files branch October 12, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

@drpatelh drpatelh Awaiting requested review from drpatelh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamrtalbot @maxulysse