Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine tags used for workflows #263

Merged
merged 6 commits into from
Feb 1, 2024
Merged

Refine tags used for workflows #263

merged 6 commits into from
Feb 1, 2024

Conversation

drpatelh
Copy link
Member

@drpatelh drpatelh commented Jan 31, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2024 •
edited
Loading

nf-core lint overall result: Failed ❌

Posted for pipeline commit a70d97e

+| ✅ 147 tests passed       |+
#| ❔   9 tests were ignored |#
!| ❗   6 tests had warnings |!
-| ❌   1 tests failed       |-

❌ Test failures:

  • files_unchanged - assets/sendmail_template.txt does not match the template

❗ Test warnings:

  • files_exist - File not found: assets/multiqc_config.yml
  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • files_exist - File not found: lib/WorkflowFetchngs.groovy
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_exist - File is ignored: conf/modules.config
  • files_exist - File is ignored: lib/NfcoreTemplate.groovy
  • files_exist - File is ignored: lib/Utils.groovy
  • files_exist - File is ignored: lib/WorkflowMain.groovy
  • files_unchanged - File does not exist: lib/NfcoreTemplate.groovy
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml
  • actions_ci - actions_ci
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/fetchngs/fetchngs/.github/workflows/awstest.yml
  • multiqc_config - 'assets/multiqc_config.yml' not found

✅ Tests passed:

Run details

  • nf-core/tools version 2.12
  • Run at 2024-02-01 08:36:28

maxulysse
maxulysse reviewed Feb 1, 2024
View reviewed changes
modules/nf-core/custom/sratoolsncbisettings/tests/main.nf.test
@@ -11,11 +11,12 @@ nextflow_process {
params {
settings_path = '/tmp/.ncbi'
settings_file = "${params.settings_path}/user-settings.mkfg"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
settings_file = "${params.settings_path}/user-settings.mkfg"
settings_file = "${params.settings_path}/user-settings.mkfg"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed this one though in nf-core/modules#4827 🤦🏽 It's ok. I have already added to the merge queue so it can be updated later if required.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, nevermind that one, I didn't pay attention it was a nf-core/module and not a local one.

maxulysse
maxulysse approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor code polish

@drpatelh drpatelh merged commit baed599 into nf-core:dev Feb 1, 2024
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drpatelh @maxulysse