Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix diagram version numbers #334

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Fix diagram version numbers #334

merged 1 commit into from
Jan 31, 2024

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Jan 31, 2024

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/funcscan branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2024 •
edited
Loading

nf-core lint overall result: Failed ❌

Posted for pipeline commit 071f357

+| ✅ 205 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   1 tests had warnings |!
-| ❌  15 tests failed       |-

❌ Test failures:

  • files_exist - File must be removed: lib/nfcore_external_java_deps.jar
  • nextflow_config - Config default value incorrect: params.annotation_prokka_evalue is set as 1e-06 in nextflow_schema.json but is 0.000001 in nextflow.config.
  • nextflow_config - Config default value incorrect: params.amp_ampcombi_cutoff is set as 0.4 in nextflow_schema.json but is 0 in nextflow.config.
  • nextflow_config - Config default value incorrect: params.arg_amrfinderplus_identmin is set as -1.0 in nextflow_schema.json but is -1 in nextflow.config.
  • nextflow_config - Config default value incorrect: params.arg_deeparg_alignmentevalue is set as 1e-10 in nextflow_schema.json but is 1E-10 in nextflow.config.
  • nextflow_config - Config default value incorrect: params.bgc_gecco_pfilter is set as 1e-09 in nextflow_schema.json but is 1E-9 in nextflow.config.
  • files_unchanged - .github/workflows/branch.yml does not match the template
  • files_unchanged - .github/workflows/linting_comment.yml does not match the template
  • files_unchanged - .github/workflows/linting.yml does not match the template
  • files_unchanged - assets/email_template.html does not match the template
  • files_unchanged - assets/email_template.txt does not match the template
  • files_unchanged - assets/nf-core-funcscan_logo_light.png does not match the template
  • files_unchanged - docs/images/nf-core-funcscan_logo_light.png does not match the template
  • files_unchanged - docs/images/nf-core-funcscan_logo_dark.png does not match the template
  • files_unchanged - pyproject.toml does not match the template

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.12
  • Run at 2024-01-31 14:27:36

jasmezz
jasmezz approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@jasmezz jasmezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you, @jfy133! Let's wait for the template-merge in order to get the linting check passing.

@jfy133
Copy link
Member Author

jfy133 commented Jan 31, 2024

Nah it's OK this won't effect anthing for the linting

@jfy133 jfy133 merged commit ca8d503 into dev Jan 31, 2024
15 of 16 checks passed
@jfy133 jfy133 deleted the fix-diagram-vernr branch January 31, 2024 15:56
@jfy133 jfy133 mentioned this pull request Feb 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasmezz jasmezz jasmezz approved these changes

@louperelo louperelo Awaiting requested review from louperelo

@Darcy220606 Darcy220606 Awaiting requested review from Darcy220606

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfy133 @jasmezz